Differential D27404

Hide empty top-level menu items
ClosedPublic
Actions

Authored by alnikiforov on Feb 14 2020, 3:17 PM.

Details

Reviewers
yurchor
mlaurent
ltoscano
Commits
R125:4bb32e2da884: Hide empty top-level menu items
Summary

If there's no data, it looks like it's bugged. Let's hide it in such case.

Similar to: D27403

Test Plan
  1. Start khelpcenter
  2. Open every top level menu item
  3. Every top level item shouldn't be empty

For me, top level items "Konqueror Settings Modules" and "Other Settings Modules" are empty. With this change they'd be hidden instead.

Diff Detail

Repository
R125 KHelpCenter
Lint
Lint Skipped
Unit
Unit Tests Skipped
alnikiforov created this revision.Feb 14 2020, 3:17 PM
Restricted Application added a project: Documentation. · View Herald TranscriptFeb 14 2020, 3:17 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
alnikiforov requested review of this revision.EditedFeb 14 2020, 3:17 PM

Here's how empty "Other Settings Modules" entry looks when selected:

alnikiforov added a comment.Feb 18 2020, 12:15 PM

Could you please take a look at this change as well?

mlaurent accepted this revision.Feb 18 2020, 12:24 PM

seems ok for me

This revision is now accepted and ready to land.Feb 18 2020, 12:24 PM
Closed by commit R125:4bb32e2da884: Hide empty top-level menu items (authored by alnikiforov, committed by yurchor). · Explain WhyMar 4 2020, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkhelpcenter/navigator.cpp (4 lines)

Diff 75694

View Options

khelpcenter/navigator.cpp

Loading...