Make it possible to change the sorting when searching
Needs RevisionPublic

Authored by apol on Fri, Feb 14, 3:07 PM.

Details

Reviewers
ngraham
Summary

We were hiding it because sorting wouldn't work when we have the relevancy on, so now we'll disable it when searching something else.

BUG: 399502

Test Plan

Used it, seems to work fine.

Diff Detail

Repository
R134 Discover Software Store
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22489
Build 22507: arc lint + arc unit
apol created this revision.Fri, Feb 14, 3:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 14, 3:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Fri, Feb 14, 3:07 PM
ngraham requested changes to this revision.Fri, Feb 14, 3:10 PM

When you switch from relevance to something else, that entry *disappears entirely* from the menu! That's rather odd. You should be able to return to sorting by relevance if you switch to a different sort order and don't like the presentation.

discover/qml/ApplicationsListPage.qml
84

"Relevance"

This revision now requires changes to proceed.Fri, Feb 14, 3:10 PM
apol added a comment.Fri, Feb 14, 3:21 PM

When you switch from relevance to something else, that entry *disappears entirely* from the menu! That's rather odd. You should be able to return to sorting by relevance if you switch to a different sort order and don't like the presentation.

Right, should. We'd have to keep a copy of every resource which is quite dangerous for several reasons and would need a bunch of duplicated code. I'd say the question is whether this is an improvement over the status quo or not.

Being able to sort search results in different ways is a nice feature for sure. But the desire for it arises from dissatisfaction with the default "relevance" search results. We might want to still do this, but the pressure for it could be reduced if the relevance algorithm returned more relevant results.

apol added a comment.Fri, Feb 14, 4:31 PM

Being able to sort search results in different ways is a nice feature for sure. But the desire for it arises from dissatisfaction with the default "relevance" search results. We might want to still do this, but the pressure for it could be reduced if the relevance algorithm returned more relevant results.

This was supposedly improved on the last libappstream releases. Can you check that you're on the last stable release?

I'm on Tumbleweed and everything is up to date, but hmm, I see that libappstream is still at 0.12.7, not 0.12.10, the current release. I wonder why that is.