Differential D27401

[applets/SystemTray] Fix crash on shutdown
ClosedPublic
Actions

Authored by kmaterka on Feb 14 2020, 1:17 PM.

Details

Reviewers
broulik
ngraham
Group Reviewers
Plasma: Workspaces
Plasma
Commits
R120:ccd4536a6ce8: [applets/SystemTray] Fix crash on shutdown
Summary

When having expanded System Tray once, plasmashell crashes on teardown.
Fixes regression introduced in D27085.

BUG: 417552
FIXED-IN: 5.19.0

Test Plan
  1. Start plasmashell
  2. Open System Tray popup, close it again
  3. run kquitapp5 plasmashell, it should not crash

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka requested review of this revision.Feb 14 2020, 1:17 PM
kmaterka created this revision.
kmaterka edited the summary of this revision. (Show Details)Feb 14 2020, 1:18 PM
anthonyfieroni added a subscriber: anthonyfieroni.Feb 14 2020, 1:27 PM

It should target 5.18.

broulik added a comment.Feb 14 2020, 1:28 PM

Luckily, the change is only in master anyway

ngraham retitled this revision from [SysterTray] Fix crash on shutdown to [applets/SystemTray] Fix crash on shutdown.Feb 14 2020, 1:38 PM
ngraham accepted this revision.Feb 14 2020, 2:23 PM
This revision is now accepted and ready to land.Feb 14 2020, 2:23 PM
Closed by commit R120:ccd4536a6ce8: [applets/SystemTray] Fix crash on shutdown (authored by kmaterka). · Explain WhyFeb 14 2020, 6:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75723

View Options

applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

Loading...