[desktoppackage] Fix layout when an applet has no custom config modules
AcceptedPublic

Authored by davidedmundson on Fri, Feb 14, 12:07 PM.

Details

Reviewers
ngraham
Summary

There was some broken code to hide the sidebar when we only have one
module. However at some point it seems half was removed, half wasn't.

This leads to the content overlapping the sidebar frame, but the sidebar
was invisible and it looks generally broken.

This patch completes the removal.

BUG: 410770

Test Plan

Opened touchpad KCM
Saw the one module (keyboard shortcuts)
Sidebar was visible, and nothing was overlapping

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.18
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22482
Build 22500: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 14, 12:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Fri, Feb 14, 12:07 PM
davidedmundson retitled this revision from [desktoppackage] Fix layout when to [desktoppackage] Fix layout when an applet has no custom config modules.Fri, Feb 14, 12:15 PM

This patch fixes the issue, but I do still see the sidebar with only one category in it:

broulik added inline comments.
desktoppackage/contents/configuration/AppletConfiguration.qml
167

Can you instead bind this to the count of the three Repeaters below? I don't get why it would overlap if it's not visible since we're in a RowLayout here?

This patch fixes the issue, but I do still see the sidebar

I meant to phrase that as

this patch completes the removal of the code, so that we always show the sidebar

I don't get why it would overlap if it's not visible since we're in a RowLayout here?

Because the background to the categories view isn't in the categories view.
There's some rectangles at the top that don't update. The content is clashing with these.

Fixing that would be an alternate solution to the problem

ngraham accepted this revision.Fri, Feb 14, 3:07 PM

This patch fixes the issue, but I do still see the sidebar

I meant to phrase that as

this patch completes the removal of the code, so that we always show the sidebar

Gotcha.

This revision is now accepted and ready to land.Fri, Feb 14, 3:07 PM