support icon.width/height
ClosedPublic

Authored by mart on Feb 14 2020, 10:57 AM.

Details

Summary

support the icon size hint of the control. Reinstate it in ToolButton
and add the support for the other controls
CCBUG:417514

Test Plan

possible to control buttons icon sizes
mediacontroller taskbar tooltip with icons set to small:

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
phab/iconSize
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22478
Build 22496: arc lint + arc unit
mart created this revision.Feb 14 2020, 10:57 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 14 2020, 10:57 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Feb 14 2020, 10:57 AM

Don't we want to set a default? I keep seeing people hardcoding icon.width all over the place when they used PC3 and I want that to stop

mart edited the test plan for this revision. (Show Details)Feb 14 2020, 11:00 AM

Don't we want to set a default? I keep seeing people hardcoding icon.width all over the place when they used PC3 and I want that to stop

then should be i think smallMedium size for toolbuttons (and i guess tabbuttons) and small for normal pushbuttons

mart updated this revision to Diff 75675.Feb 14 2020, 11:11 AM
  • default icon sizes
mart updated this revision to Diff 75677.Feb 14 2020, 11:33 AM
  • don't expose externally default size
broulik accepted this revision.Feb 14 2020, 11:36 AM
This revision is now accepted and ready to land.Feb 14 2020, 11:36 AM
This revision was automatically updated to reflect the committed changes.