[RFC] Return error instead of aborting when receiving an unexpected answer
Needs ReviewPublic

Authored by fifr on Feb 13 2020, 8:32 PM.

Details

Reviewers
dfaure
meven
Group Reviewers
Frameworks
Summary

If SlaveBase::waitForAnswer receives an unexpected subcommand it aborts by calling qFatal. However, an unexpected subcommand could be received due to external causes, hence the error should be handled properly instead of abort.

BUG: 416895
FIXED-IN: 5.68

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
fifr created this revision.Feb 13 2020, 8:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 13 2020, 8:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
fifr requested review of this revision.Feb 13 2020, 8:32 PM
fifr retitled this revision from Return error instead of aborting when receiving an unexpected answer to [RFC] Return error instead of aborting when receiving an unexpected answer.
fifr added a reviewer: kiokiio.
nicolasfella edited reviewers, added: Frameworks, dfaure, meven; removed: kiokiio.Feb 13 2020, 8:38 PM
broulik added inline comments.
src/core/slavebase.cpp
1100

Should at least be qWarning imho