Differential D27382

KCM: Fix connection list background and padding
ClosedPublic
Actions

Authored by ahiemstra on Feb 13 2020, 7:35 PM.

Details

Reviewers
jgrulich
davidedmundson
Group Reviewers
Plasma
Commits
R116:04cd1f337fef: KCM: Fix connection list background and padding
R116:f8a60c63876f: KCM: Fix connection list background and padding
Summary

Like D27379 the ListView in the Network Management KCM is incorrectly anchored to its parent ScrollView. This removes the anchoring, removing overlap of the scrollbar. In addition, it corrects the ScrollView's background so it actually displays correctly.

Test Plan

Before:

After:

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
scrollview_anchor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22447
Build 22465: arc lint + arc unit
ahiemstra created this revision.Feb 13 2020, 7:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 7:35 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Feb 13 2020, 7:35 PM
ahiemstra edited the summary of this revision. (Show Details)Feb 13 2020, 7:39 PM
ahiemstra edited the test plan for this revision. (Show Details)
ahiemstra added a reviewer: Plasma.
davidedmundson accepted this revision.Feb 13 2020, 7:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2020, 10:31 AM
Closed by commit R116:f8a60c63876f: KCM: Fix connection list background and padding (authored by ahiemstra). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/qml/main.qml (5 lines)

Diff 75636

View Options

kcm/qml/main.qml

Loading...