[sidebar] Resolve changes in module before switching
ClosedPublic

Authored by davidedmundson on Feb 13 2020, 7:32 PM.

Details

Summary

After some refactoring we close the module before checking if there are
unsaved changes. We then try to resolve changes on the new KCM that
we've just opened, which never has changes.

BUG: 416834
Fixed-in: 5.18.1

Test Plan

Opened colours in systemsettings
changed it
switched to another kcm

Did the same from within a search

opened kinfocenter
no prompts

Diff Detail

Repository
R124 System Settings
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22446
Build 22464: arc lint + arc unit
davidedmundson created this revision.Feb 13 2020, 7:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 7:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 13 2020, 7:32 PM
bport accepted this revision.Feb 13 2020, 9:31 PM
bport added a subscriber: bport.

Can reproduce bug and fix work as expected

This revision is now accepted and ready to land.Feb 13 2020, 9:31 PM
ngraham accepted this revision.Feb 13 2020, 10:02 PM
ngraham added a subscriber: ngraham.

^^ same

This revision was automatically updated to reflect the committed changes.