Baloo KCM: Do not anchor fill ScrollView

Authored by ahiemstra on Feb 13 2020, 5:46 PM.



ScrollView will resize any single child flickabe to the right size.
However, this behaviour breaks if that child specifies anchors,
causing the child to ignore any padding specified in ScrollView.
Removing the anchoring fixes the scrollbar overlapping and also
fixes list items poking outside the scrollview border.

BUG: 417437
FIXED-IN: 5.18.1

Test Plan



Diff Detail

R119 Plasma Desktop
No Linters Available
No Unit Test Coverage
Build Status
Buildable 22442
Build 22460: arc lint + arc unit
ahiemstra created this revision.Feb 13 2020, 5:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 5:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Feb 13 2020, 5:46 PM
ahiemstra edited the test plan for this revision. (Show Details)Feb 13 2020, 5:49 PM
ngraham accepted this revision.Feb 13 2020, 6:00 PM
This revision is now accepted and ready to land.Feb 13 2020, 6:00 PM

What I don't understand from this patch is that plasmathemeexplorer which has the same anchors but uses a gridview doesn't have this problem
Nor plasma NM's Add Connection Dialog

Both use QtQuick Controls 1 ScrollView, which works quite a bit different if I recall correctly. So they are not really comparable.

davidedmundson accepted this revision.Feb 13 2020, 7:19 PM

Cool, I'm happy as long as there's a known reason.

This revision was automatically updated to reflect the committed changes.