Baloo KCM: Do not anchor fill ScrollView
ClosedPublic

Authored by ahiemstra on Thu, Feb 13, 5:46 PM.

Details

Summary

ScrollView will resize any single child flickabe to the right size.
However, this behaviour breaks if that child specifies anchors,
causing the child to ignore any padding specified in ScrollView.
Removing the anchoring fixes the scrollbar overlapping and also
fixes list items poking outside the scrollview border.

BUG: 417437
FIXED-IN: 5.18.1

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Thu, Feb 13, 5:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Feb 13, 5:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Thu, Feb 13, 5:46 PM
ahiemstra edited the test plan for this revision. (Show Details)Thu, Feb 13, 5:49 PM
ngraham accepted this revision.Thu, Feb 13, 6:00 PM
This revision is now accepted and ready to land.Thu, Feb 13, 6:00 PM

What I don't understand from this patch is that plasmathemeexplorer which has the same anchors but uses a gridview doesn't have this problem
Nor plasma NM's Add Connection Dialog

Both use QtQuick Controls 1 ScrollView, which works quite a bit different if I recall correctly. So they are not really comparable.

davidedmundson accepted this revision.Thu, Feb 13, 7:19 PM

Cool, I'm happy as long as there's a known reason.

This revision was automatically updated to reflect the committed changes.