map ECONNABORTED to ERR_CONNECTION_BROKEN
ClosedPublic

Authored by sitter on Feb 13 2020, 5:15 PM.

Details

Summary

seems the most reasonable candidate given the pretty strings in
KIO::buildErrorString and the detailed causes in the detail function.

this does not really improve the error message, but should dolphin
ever learn to pick up details from detailedErrorStrings it would make
diagnosing easier.

ECONNABORTED can mean any number of things, so I guess a signle line
error will always be incredibly vague.

BUG: 415436
FIXED-IN: 19.12.3

Test Plan

hoping for the best!

Diff Detail

Repository
R320 KIO Extras
Branch
bug415436
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22440
Build 22458: arc lint + arc unit
sitter created this revision.Feb 13 2020, 5:15 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 13 2020, 5:15 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 13 2020, 5:15 PM

I think this is reasonable and at least a small improvement given the limitations at play here.

ngraham accepted this revision.Feb 13 2020, 5:21 PM
This revision is now accepted and ready to land.Feb 13 2020, 5:21 PM
This revision was automatically updated to reflect the committed changes.