Next step after porting the settings to KConfigXT. I recreated the layout as it
was before. Additionaly the KUrlRequester for the default save location now
only accepts folders.
Details
Details
- Reviewers
ervin ngraham - Group Reviewers
Spectacle - Commits
- R166:c013771e146d: Port general settings and save setting to ui files
Works as before
Diff Detail
Diff Detail
- Repository
- R166 Spectacle
- Branch
- settings.ui
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22854 Build 22872: arc lint + arc unit
Comment Actions
Couple of nitpicks, feel free to ignore
src/Gui/SettingsDialog/GeneralOptionsPage.h | ||
---|---|---|
35 | Nitpick, feel free to ignore: you can spare this if you go for using QScopedPointer in m_ui | |
src/Gui/SettingsDialog/SaveOptionsPage.cpp | ||
68 | There is an extra space after the opening parenthesis which probably shouldn't be here |
src/Gui/SettingsDialog/GeneralOptionsPage.h | ||
---|---|---|
35 | How would I do that with an incomplete type? |
src/Gui/SettingsDialog/GeneralOptionsPage.h | ||
---|---|---|
35 | Oh right, QScopedPointer needs the type to be complete... Well you could at least use "= default" in the cpp for the dtor. So it'd still be declared but you wouldn't have to bother providing an implementation yourself. |
src/Gui/SettingsDialog/GeneralOptionsPage.h | ||
---|---|---|
35 | Does that free *m_ui? |
src/Gui/SettingsDialog/GeneralOptionsPage.h | ||
---|---|---|
35 | Well, if it's a QScopedPointer yes. ;-) This avoids the problem with incomplete types you mentioned earlier. |