Fix metainfo generation for Amarok applets
ClosedPublic
Actions

Authored by pgomes on Feb 13 2020, 2:17 PM.

Details

Reviewers

amarok-devel
heikobecker

Group Reviewers

Amarok

Commits

R181:7feeea8583fa: Fix metainfo generation for Amarok applets

Summary

Cmake reports the following error when processing metadata.desktop file for Amarok's applets: lyrics, analyzer, wikipedia, etc.

Error: description missing, will result in broken appdata field as
<sumary/> is mandatory at
/amarok/src/context/applets/albums/package/metadata.desktop

The error is because such .desktop files do not have a "Comment=" field. I have added such to all files

Test Plan

Run cmake and see that the error is not preset.

Diff Detail

Repository

R181 Amarok

Lint

Lint Skipped

Unit

Unit Tests Skipped

pgomes created this revision.Feb 13 2020, 2:17 PM

pgomes created this object with edit policy "Administrators".

Restricted Application removed a project: Amarok. · View Herald TranscriptFeb 13 2020, 2:17 PM

Restricted Application added subscribers: amarok-devel, Amarok. · View Herald Transcript

pgomes requested review of this revision.Feb 13 2020, 2:17 PM

pgomes added reviewers: Amarok, amarok-devel.Feb 13 2020, 2:48 PM

pgomes edited the summary of this revision. (Show Details)Feb 17 2020, 10:43 AM

Thanks!

Do you have commit access or should I push this for you?

This revision is now accepted and ready to land.Feb 21 2020, 3:43 PM

I don't have commit privilege yet. Please push this and any other approved commit.

In D27370#615218, @heikobecker wrote:

Thanks!

Do you have commit access or should I push this for you?

If you give me your email address I'll properly set the git authorship information.

Closed by commit R181:7feeea8583fa: Fix metainfo generation for Amarok applets (authored by pgomes, committed by heikobecker). · Explain WhyFeb 25 2020, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/context/applets/albums/package/metadata.desktop (1 line)
M			src/context/applets/analyzer/package/metadata.desktop (1 line)
M			src/context/applets/currenttrack/package/metadata.desktop (1 line)
M			src/context/applets/lyrics/package/metadata.desktop (1 line)
M			src/context/applets/photos/package/metadata.desktop (1 line)
M			src/context/applets/wikipedia/package/metadata.desktop (1 line)