Differential D27368

[Styles KCM] Set style display name as window title
ClosedPublic
Actions

Authored by broulik on Feb 13 2020, 1:44 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:bc5c45e8aa9d: [Styles KCM] Set style display name as window title
Summary

StyleConfigDialog doesn't actually load the config plugin, so it doesn't use the argument for loading but displaying.
Pass the display of the style to ensure a correct window title.

BUG: 417563
FIXED-IN: 5.18.1

Test Plan

Shows "Configure Breeze" now

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 13 2020, 1:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 1:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 13 2020, 1:44 PM
davidedmundson accepted this revision.Feb 13 2020, 2:17 PM
This revision is now accepted and ready to land.Feb 13 2020, 2:17 PM
Closed by commit R119:bc5c45e8aa9d: [Styles KCM] Set style display name as window title (authored by broulik). · Explain WhyFeb 13 2020, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75612

View Options

kcms/style/kcmstyle.h

Loading...
View Options

kcms/style/kcmstyle.cpp

Loading...
View Options

kcms/style/package/contents/ui/main.qml

Loading...