Differential D27366

Construct NullEngine with KPluginMetaData()
ClosedPublic
Actions

Authored by broulik on Feb 13 2020, 12:33 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R242:1dc36bc2cee4: Construct NullEngine with KPluginMetaData()
Summary

The deprecated constructor taking a KPluginInfo unconditionally calls toMetaData() and then asserts.

BUG: 417557

Test Plan
  • Compiles. Can't actually reproduce the crash, even when I delete my geolocation dataengine

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 13 2020, 12:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 13 2020, 12:33 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Feb 13 2020, 12:33 PM
apol accepted this revision.Feb 13 2020, 2:19 PM
This revision is now accepted and ready to land.Feb 13 2020, 2:19 PM
Closed by commit R242:1dc36bc2cee4: Construct NullEngine with KPluginMetaData() (authored by broulik). · Explain WhyFeb 13 2020, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75613

View Options

src/plasma/private/dataenginemanager.cpp

Loading...