Differential D27365

fix condition in KonsoleProfiles::run
ClosedPublic
Actions

Authored by McPain on Feb 13 2020, 12:16 PM.

Details

Reviewers
heikobecker
ngraham
Commits
R114:f0431c95a895: fix condition in KonsoleProfiles::run
Summary

Looks like there's a typo and it's not intended to exec "konsole --profile" with empty profile string because the funxtion returns early when profile is not empty.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
McPain created this revision.Feb 13 2020, 12:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 12:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Feb 13 2020, 12:16 PM
McPain added a comment.Feb 13 2020, 12:26 PM

Happens to be a regression after 2f3bcfa

alex added a subscriber: alex.Feb 14 2020, 6:41 PM

Hello,
I have already created a patch for this (and some other improvements) which is currently waiting to be reviewed: https://phabricator.kde.org/D27098

ngraham accepted this revision.Feb 18 2020, 4:24 PM
ngraham added a subscriber: ngraham.

Thanks for your patch @alex. However since this is a targeted bugfix, I would like to land it now on the stable branch. Since your patch includes refactoring, it needs to go into the next release. I'll land this now, and then you can remove this bugfix from your patch. Thanks!

This revision is now accepted and ready to land.Feb 18 2020, 4:24 PM
Closed by commit R114:f0431c95a895: fix condition in KonsoleProfiles::run (authored by McPain, committed by ngraham). · Explain WhyFeb 18 2020, 4:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75929

View Options

runners/konsoleprofiles/konsoleprofiles.cpp

Loading...