Differential D27359

[Server] Don't use deprecated QSet methods and minor code improvements
ClosedPublic
Actions

Authored by ahmadsamir on Feb 13 2020, 10:09 AM.

Details

Reviewers
psn
hein
mlaurent
Group Reviewers
Konversation
Commits
R7:fd65a2c30d75: [Server] Don't use deprecated QSet methods and minor code improvements
Summary

Drop one usage of QSet::fromList(), and use QList::removeDuplicates()
instead, assuming the conversion for QList to QSet was to remove
duplicates.

Return early if nameValue is empty, this also guards against accesing
an out of bounds index.

Use QList::at() instead of [], to prevent detaching.

Test Plan

using sasl still works

Diff Detail

Repository
R7 Konversation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir requested review of this revision.Feb 13 2020, 10:09 AM
ahmadsamir created this revision.
psn accepted this revision.Mar 3 2020, 2:23 PM

looks good to me

This revision is now accepted and ready to land.Mar 3 2020, 2:23 PM
Closed by commit R7:fd65a2c30d75: [Server] Don't use deprecated QSet methods and minor code improvements (authored by ahmadsamir). · Explain WhyMar 3 2020, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/irc/server.cpp (18 lines)

Diff 76853

View Options

src/irc/server.cpp

Loading...