[Server] Don't use deprecated QSet methods and minor code improvements
Needs ReviewPublic

Authored by ahmadsamir on Thu, Feb 13, 10:09 AM.

Details

Reviewers
psn
hein
mlaurent
Group Reviewers
Konversation
Summary

Drop one usage of QSet::fromList(), and use QList::removeDuplicates()
instead, assuming the conversion for QList to QSet was to remove
duplicates.

Return early if nameValue is empty, this also guards against accesing
an out of bounds index.

Use QList::at() instead of [], to prevent detaching.

Test Plan

using sasl still works

Diff Detail

Repository
R7 Konversation
Branch
l-fromList (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22423
Build 22441: arc lint + arc unit
ahmadsamir requested review of this revision.Thu, Feb 13, 10:09 AM
ahmadsamir created this revision.