Differential D27358

Sync ("Wayland") appending to match SDDM
ClosedPublic
Actions

Authored by davidedmundson on Feb 13 2020, 9:42 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R123:5c8f1db8ec21: Merge branch 'Plasma/5.18'
R123:c0fdf0039be4: Sync ("Wayland") appending to match SDDM
Summary

For historical reasons some .desktop files in wayland-sessions suffix
their .desktop files, some expect the display manager to do it.

SDDM compares the suffix and only adds if needed. Our config UI should
match exactly.

The obvious comment is this only works in English, but for some reason
both SDDM and this code only read the Name entry in English anyway.

BUG: 417499

Test Plan

Opened KCM

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 13 2020, 9:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 9:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 13 2020, 9:42 AM
ngraham accepted this revision.Feb 13 2020, 9:44 PM
ngraham added a subscriber: ngraham.

Wasn't this something that SDDM was going to stop doing in its next release?

This revision is now accepted and ready to land.Feb 13 2020, 9:44 PM
davidedmundson added a comment.Feb 14 2020, 12:21 AM

Given we have that .endsWith("Wayland") check, there isn't any rush to remove it

Closed by commit R123:c0fdf0039be4: Sync ("Wayland") appending to match SDDM (authored by davidedmundson). · Explain WhyFeb 14 2020, 1:03 PM
This revision was automatically updated to reflect the committed changes.
fvogt added a subscriber: fvogt.Feb 18 2020, 2:44 PM

Note that this behaviour of sddm is not in any release yet - only in git.

Revision Contents
Changeset List

PathPackages
Msrc/sessionmodel.cpp (7 lines)

Diff 75689

View Options

src/sessionmodel.cpp

Loading...