Differential D27351

call smb_cutime on the correct url to actually set mtime properly
ClosedPublic
Actions

Authored by sitter on Feb 12 2020, 3:38 PM.

Details

Reviewers
ngraham
Commits
R320:aaedd983729f: smb: call smb_cutime on the correct url to actually set mtime properly
Summary

since the introduction of partial resume dstUrl would can be the .part url
whereas dstOrigUrl is the final destination url.

i.e.
we called smbc_utime on smb://foo/bar.part rather than smb://foo/bar

BUG: 356651
FIXED-IN: 19.12.3

Test Plan

moving file to smb retains mtime

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 12 2020, 3:38 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 12 2020, 3:38 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 12 2020, 3:38 PM
ngraham accepted this revision.Feb 12 2020, 4:42 PM

It works! Fantastic!

This revision is now accepted and ready to land.Feb 12 2020, 4:42 PM
Closed by commit R320:aaedd983729f: smb: call smb_cutime on the correct url to actually set mtime properly (authored by sitter). · Explain WhyFeb 13 2020, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_dir.cpp (2 lines)

Diff 75598

View Options

smb/kio_smb_dir.cpp

Loading...