Differential D27344

[Notifications] Only let details label grow, never shrink
ClosedPublic
Actions

Authored by broulik on Feb 12 2020, 1:29 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:0fb8e51b8e13: [Notifications] Only let details label grow, never shrink
Summary

Avoids repeatedly resizing the dialog when copying many files.
It will still resize when the speed label comes and goes but at least when copying many tiny files it won't be as obnoxious.

BUG: 417489
FIXED-IN: 5.18.1

Test Plan

Copied files with varying name lengths to another location.
Dialog didn't jump around like crazy anymore, instead I sometimes had a gap between Destination and number of files copied.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 12 2020, 1:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 12 2020, 1:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 12 2020, 1:29 PM
ngraham accepted this revision.Feb 12 2020, 4:26 PM
ngraham added a subscriber: ngraham.

Ah, this was mildly annoying me recently. Nice fix.

This revision is now accepted and ready to land.Feb 12 2020, 4:26 PM
Closed by commit R120:0fb8e51b8e13: [Notifications] Only let details label grow, never shrink (authored by broulik). · Explain WhyFeb 13 2020, 9:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75582

View Options

applets/notifications/package/contents/ui/JobDetails.qml

Loading...