Is zwp_input_panel_surface_v1 yet another surface role, like xdg_toplevel or wl_subsurface?

it's just an interface that provides us a surface and some information on how to place it on the screen.

I'm a little bit concerned about the case where one wants to get a zwp_input_panel_surface_v1 for a wl_surface which is also an xdg_toplevel or xdg_popup. In that case, the wl_surface will be represented by two XdgShellClient objects!

Perhaps we need to install an InputPanelSurfaceInterface rather than create a new XdgShellClient for it. For what it's worth, that's how we handle plasma surfaces (org_kde_plasma_surface).

void XdgShellClient::installInputPanelSurface(InputPanelSurfaceInterface *surface)
{
    m_inputPanelSurface = surface;

    // a bunch of connects
}

I'm not sure that's a problem. I do know that at the moment the surfaces aren't created at all otherwise, be it from weston-keyboard or maliit (Qt).

oh, no.... it seems like zwp_input_panel_surface_v1 is yet another surface role, which means it can't be represented by XdgShellClient.

I don't see where it's implemented. Delete it? By the way, we have killWindow().

Use frameGeometryChanged instead of geometryShapeChanged.

Leave it in createSurface(). You can't use xdg-foreign with non xdg_toplevel equivalent surfaces.

s/createInputPanelSurface/createInputPanelClient/