Return early if close button accepts input event
ClosedPublic

Authored by davidedmundson on Feb 11 2020, 9:29 PM.

Details

Summary

Otherwise we close the effect whenever the close is pressed which is a
behavioural change.

That in turn leads to bigger bugs

BUG: 415155

Test Plan

Ran effect
Clicked on the "Whitespace" of the dash
Clicked on the close

Now matches desktopgrid code

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22376
Build 22394: arc lint + arc unit
davidedmundson created this revision.Feb 11 2020, 9:29 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 11 2020, 9:29 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Feb 11 2020, 9:29 PM
zzag added a subscriber: zzag.Feb 11 2020, 10:22 PM
zzag added inline comments.
effects/presentwindows/presentwindows.cpp
541

Wouldn't it be better to check QEvent::isAccepted() in EffectsHandlerImpl::checkInputWindowEvent()?

zzag accepted this revision.Feb 11 2020, 10:50 PM
zzag added inline comments.
effects/presentwindows/presentwindows.cpp
541

Urgh, no, it seems like n effects can do mouse interception by design, please ignore me.

This revision is now accepted and ready to land.Feb 11 2020, 10:50 PM
ngraham accepted this revision.Feb 12 2020, 12:48 AM
ngraham added a subscriber: ngraham.

Fixes the bug. Can we get this on the stable branch?

This revision was automatically updated to reflect the committed changes.