Make Taskmanager's tooltip a fixed ratio rectangle
AbandonedPublic

Authored by trmdi on Feb 11 2020, 5:28 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Plasma
Test Plan

The size of tooltips are not changed between cases:
e.g. a normal window vs a window which is available on all activities,
e.g. a normal window vs a window which has a player...



Diff Detail

Repository
R119 Plasma Desktop
Branch
adjust-size-of-tooltip (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22373
Build 22391: arc lint + arc unit
trmdi created this revision.Feb 11 2020, 5:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 11 2020, 5:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Feb 11 2020, 5:28 PM
trmdi edited the test plan for this revision. (Show Details)Feb 11 2020, 5:35 PM
trmdi edited the test plan for this revision. (Show Details)Feb 11 2020, 5:43 PM
ngraham requested changes to this revision.Feb 11 2020, 5:48 PM
ngraham added a subscriber: ngraham.

Okay, seeing this in action, I don't hate it. However I feel like my concern with the album art being squeezed too much is valid:

Even the windows previews get squeezed a lot:

If we're going to do this, I think the rectangle should be either larger or taller.

This revision now requires changes to proceed.Feb 11 2020, 5:48 PM
trmdi updated this revision to Diff 75486.Feb 11 2020, 6:10 PM
  • Increase the height a bit
trmdi added a comment.Feb 11 2020, 6:12 PM

We can increase the height a bit, but not sure which ratio is the best.
Another thing is that, even with a bigger thumbnail, we could hardly see its content, so making it bigger doesn't make it more clear.

Okay, seeing this in action, I don't hate it. However I feel like my concern with the album art being squeezed too much is valid:

Even the windows previews get squeezed a lot:

If we're going to do this, I think the rectangle should be either larger or taller.

We should avoid making it larger, otherwise it looks ugly on small screens.
Does the 1.5 ratio look better to you?

That's better, though I dunno, I can't shake the feeling that the album art is still too compressed:

Maybe I'm just being crotchety though. VDG folks, what does everyone else think?

filipf added a subscriber: filipf.Feb 11 2020, 6:42 PM

That's better, though I dunno, I can't shake the feeling that the album art is still too compressed.

Me too.

trmdi added a comment.EditedFeb 12 2020, 2:14 AM

Hmm, I think the 1.5 ratio makes a nice shape overall while the thumbnail is also not too small.
A tooltip has texts and a thumbnail, we needn't too focus in the thumbnail as well as try to make it fill all the width.


trmdi edited the test plan for this revision. (Show Details)Feb 12 2020, 4:26 AM
trmdi added a comment.Feb 15 2020, 6:51 AM

How about this?

How about this?

You can also try the GoldNumber/Ratio that is found in all real nature patterns and also at Ancient Greeks in their architectural buildings. That is 1.618, there is a big chance that it feels right without being able to explain why.

trmdi updated this revision to Diff 75959.Feb 19 2020, 2:58 AM
  • Increase the height a bit more, the last effort.
trmdi added a comment.Feb 19 2020, 3:05 AM

How about this?

You can also try the GoldNumber/Ratio that is found in all real nature patterns and also at Ancient Greeks in their architectural buildings. That is 1.618, there is a big chance that it feels right without being able to explain why.

But others don't like a wide thumbnail. :(

trmdi abandoned this revision.Feb 19 2020, 3:19 AM