Differential D2732

[MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1
ClosedPublic
Actions

Authored by lbeltrame on Sep 10 2016, 7:57 AM.

Details

Reviewers
mart
hein
broulik
Group Reviewers
Plasma
Commits
R120:629fa121be72: [MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1
R871:629fa121be72: [MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1
Summary

While investingating properties of the MPRIS dataengine, I have noitced that the :xsesam:url property in the metadata was encoded incorrectly. I have several folders containing music with non-Latin characters, and they showed up as ????.

After a quick chat with kbroulik on IRC, I decided to make this patch, which uses UTF-8 instead.

Test Plan

Inspected plasmaeengineexplorer, URLs show up fine. No apparent change in the behavior of the plasmoid.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lbeltrame updated this revision to Diff 6607.Sep 10 2016, 7:57 AM
lbeltrame retitled this revision from to [MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1.
lbeltrame updated this object.
lbeltrame edited the test plan for this revision. (Show Details)
lbeltrame added reviewers: broulik, Plasma.
lbeltrame set the repository for this revision to R120 Plasma Workspace.
lbeltrame added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptSep 10 2016, 7:57 AM
hein accepted this revision.Sep 12 2016, 11:35 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Sep 12 2016, 11:35 AM
mart accepted this revision.Sep 12 2016, 11:36 AM
mart added a reviewer: mart.
Closed by commit R120:629fa121be72: [MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1 (authored by lbeltrame). · Explain WhySep 12 2016, 6:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6671

View Options

dataengines/mpris2/playercontainer.cpp

Loading...