Swap "Open in New Window" and "Open in New Tab" in context menus
ClosedPublic

Authored by IlyaBizyaev on Tue, Feb 11, 11:45 AM.

Details

Summary

Since Dolphin's default behaviour became opening in new tabs rather than in new windows
(a very positive change, in my opinion), I always find myself accidentally opening folders
in new windows from the context menu. This is because in most browsers with tab workflow
(e.g. Firefox, Chromium, Falkon) the top context menu action is opening in a new tab, and
my muscle memory plays a bad trick :) I'm aware of middle-clicking, but I find it
inconvenient with my touchpad.

I suspect I'm probably not alone in that, so I think it makes sense to swap these actions
in Dolphin to match widely used apps.

Test Plan

Open Dolphin, right click folders in the main view and in the Places panel, ensure the
actions are indeed swapped

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
IlyaBizyaev created this revision.Tue, Feb 11, 11:45 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptTue, Feb 11, 11:45 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
IlyaBizyaev requested review of this revision.Tue, Feb 11, 11:45 AM
ndavis accepted this revision.Tue, Feb 11, 11:48 AM
ndavis added a subscriber: ndavis.

+1

This revision is now accepted and ready to land.Tue, Feb 11, 11:48 AM

I'm not against this, but I wonder if it might make sense to conditionally swap the items only when the "open folders in tabs" is active? Or would that be more confusing?

Also keep in mind what whenever we change the ordering of menu items, there's always someone who complains, so brace yourself. :)

I'm not against this, but I wonder if it might make sense to conditionally swap the items only when the "open folders in tabs" is active? Or would that be more confusing?

I think it would be confusing. It doesn't really have anything to do with this except that they involve tabs.

I'm not against this, but I wonder if it might make sense to conditionally swap the items only when the "open folders in tabs" is active? Or would that be more confusing?

This... does sound more confusing to me, yes 😅
It's not like the order of these actions makes more sense reversed when that feature is disabled; it's quite unrelated, it's just that it made me use and appreciate Dolphin tabs more :)

Also keep in mind what whenever we change the ordering of menu items, there's always someone who complains, so brace yourself. :)

I hope this will not be the case here, since the person unsatisfied with the change has to not use graphical web browsers, but I'd imagine that such a person would then not use a GUI file manager :)
But I tightened my seatbelts, just in case.

ngraham accepted this revision.Wed, Feb 12, 3:51 PM
ngraham added a reviewer: Dolphin.

All right, go for it!

This revision was automatically updated to reflect the committed changes.