Differential D27302

Update obsolete KProcess::error
ClosedPublic
Actions

Authored by gengisdave on Feb 10 2020, 6:58 PM.

Details

Reviewers
asensi
Group Reviewers
Krusader
Commits
R167:cc9db2947ab2: Replace obsolete Kprocess:error
Summary

The signal QProcess::error(QProcess::ProcessError) is deprecated in favor of QProcess::errorOccurred(QProcess::ProcessError)

The new signal was introduced in Qt 5.6, no #if guards are needed

Test Plan

Compile and test. The changes impact when the tool Locate fails to start (e.g. not installed or without exec perms)

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gengisdave requested review of this revision.Feb 10 2020, 6:58 PM
gengisdave created this revision.
asensi accepted this revision as: asensi.Feb 19 2020, 10:30 PM
asensi added a subscriber: asensi.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

This revision is now accepted and ready to land.Feb 19 2020, 10:30 PM
Closed by commit R167:cc9db2947ab2: Replace obsolete Kprocess:error (authored by gengisdave). · Explain WhyMar 3 2020, 7:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkrusader/Locate/locate.cpp (2 lines)

Diff 76817

View Options

krusader/Locate/locate.cpp

Loading...