Differential D27293

smb: do not map uid and gid
ClosedPublic
Actions

Authored by sitter on Feb 10 2020, 4:25 PM.

Details

Reviewers
ngraham
Commits
R320:25a02064dbee: smb: do not map uid and gid
Summary

libsmbc returns the uid/gid of the process, not of the file, the data
is entirely useless to us. do not list it.
currently there is no way to get the actual uid/gid of a dirent. internally
there seems to be tech available that uses the samba unix extension but
that doesn't have any public API.

in short: we can't determine ownership client-side

BUG: 212801

Test Plan

no longer shows current user as owner. in particular when that is not true!

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 10 2020, 4:25 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 10 2020, 4:25 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 10 2020, 4:25 PM
ngraham accepted this revision.Feb 12 2020, 3:40 AM

Nice.

This revision is now accepted and ready to land.Feb 12 2020, 3:40 AM
Closed by commit R320:25a02064dbee: smb: do not map uid and gid (authored by sitter). · Explain WhyFeb 13 2020, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (20 lines)

Diff 75601

View Options

smb/kio_smb_browse.cpp

Loading...