set the share comment as UDS_COMMENT for the UI to display
ClosedPublic

Authored by sitter on Feb 10 2020, 4:24 PM.

Details

Summary

currently this seems to not really have any visibility through dolphin
so concluding the fix also requires changes to dolphin to enable the
comment somewhere. it is technically a column in the details view but
that doesn't actually seem to work

CCBUG: 105086

Test Plan

hoping for the best in absence of a UI!

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 10 2020, 4:24 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 10 2020, 4:24 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 10 2020, 4:24 PM

The comment will be shown in the status bar when hovering a file.

We talked about this on telegram and what Kai is thinking of may be the mime comment. Upon review UDS_COMMENT (or KFileItem::comment()) seems to simply not be modeled in dolphin. The model has a Comment column but as far as I can tell the data for that column is never set, which explains why dolphin doesn't show the comment even when enabling the relevant column in the details view.

ngraham accepted this revision.Feb 10 2020, 5:42 PM
This revision is now accepted and ready to land.Feb 10 2020, 5:42 PM
This revision was automatically updated to reflect the committed changes.