Adds support for slightly different PipeWire API.
Details
Details
- Reviewers
Kanedias - Commits
- R437:92c9905f3672: PW framebuffer: support upcoming PipeWire 0.3
Tested with xdg-desktop-portal-kde and new pipewire.
Diff Detail
Diff Detail
- Repository
- R437 Desktop Sharing
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22309 Build 22327: arc lint + arc unit
Comment Actions
Well, okay. I'm not happy that the whole code just got bulkier because of PW 0.3, but that's the only concern.
If you have time on your hands, please split this into two distinct implementations (PWFrameBufferV02 and PWFrameBufferV03) so you won't need to wrack your brains around #ifs in the future
All other aspects seem fine, and btw nice to see that Pipewire is starting to handle errors and be more verbose.
Approved.
Comment Actions
I would prefer not spending my time on this. I understand it's annoying using ifdefs, on the other hand I expect we remove it one day when PW 0.2 is just too old. Also PipeWire devs promised not to do any other API changes in future so I don't expect any new ifdefs in future.