PW framebuffer: support upcoming PipeWire 0.3
ClosedPublic

Authored by jgrulich on Feb 10 2020, 2:31 PM.

Details

Summary

Adds support for slightly different PipeWire API.

Test Plan

Tested with xdg-desktop-portal-kde and new pipewire.

Diff Detail

Repository
R437 Desktop Sharing
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich requested review of this revision.Feb 10 2020, 2:31 PM
jgrulich created this revision.
jgrulich updated this revision to Diff 75381.Feb 10 2020, 3:40 PM

Improve cmake file

Kanedias accepted this revision.EditedFeb 25 2020, 5:49 AM

Well, okay. I'm not happy that the whole code just got bulkier because of PW 0.3, but that's the only concern.
If you have time on your hands, please split this into two distinct implementations (PWFrameBufferV02 and PWFrameBufferV03) so you won't need to wrack your brains around #ifs in the future

All other aspects seem fine, and btw nice to see that Pipewire is starting to handle errors and be more verbose.
Approved.

This revision is now accepted and ready to land.Feb 25 2020, 5:49 AM

Well, okay. I'm not happy that the whole code just got bulkier because of PW 0.3, but that's the only concern.
If you have time on your hands, please split this into two distinct implementations (PWFrameBufferV02 and PWFrameBufferV03) so you won't need to wrack your brains around #ifs in the future

I would prefer not spending my time on this. I understand it's annoying using ifdefs, on the other hand I expect we remove it one day when PW 0.2 is just too old. Also PipeWire devs promised not to do any other API changes in future so I don't expect any new ifdefs in future.

This revision was automatically updated to reflect the committed changes.