Use ecm_qt_install_logging_categories over manual categories file
ClosedPublic
Actions

Authored by kossebau on Feb 9 2020, 8:03 PM.

Details

Reviewers

Group Reviewers

Build System
Frameworks

Commits

Test Plan

Generated file matches entries of existing manual file + 2 additional ones
not yet listed

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Feb 9 2020, 8:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2020, 1:08 AM

This revision was automatically updated to reflect the committed changes.

bruns added inline comments.

CMakeLists.txt
9	Obviously, this is no longer true. This now depends on an unreleased ECM version ...

		Path
M		CMakeLists.txt (2 lines)
D	M	kio.categories (20 lines)
M		src/CMakeLists.txt (6 lines)
M		src/core/CMakeLists.txt (32 lines)
M		src/gui/CMakeLists.txt (8 lines)
M		src/ioslaves/file/CMakeLists.txt (7 lines)
M		src/ioslaves/ftp/CMakeLists.txt (7 lines)
M		src/ioslaves/http/CMakeLists.txt (21 lines)
M		src/ioslaves/http/kcookiejar/CMakeLists.txt (7 lines)
M		src/ioslaves/remote/CMakeLists.txt (12 lines)
M		src/ioslaves/trash/CMakeLists.txt (8 lines)
M		src/kcms/kio/CMakeLists.txt (7 lines)
M		src/kiod/CMakeLists.txt (7 lines)
M		src/kioexec/CMakeLists.txt (5 lines)
M		src/kpasswdserver/CMakeLists.txt (7 lines)
M		src/urifilters/ikws/CMakeLists.txt (8 lines)
M		src/urifilters/localdomain/CMakeLists.txt (8 lines)
M		src/urifilters/shorturi/CMakeLists.txt (8 lines)
M		src/widgets/CMakeLists.txt (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	75313	2c84f4b		Feb 9 2020, 8:03 PM	★	★
Diff 2	75426	b7028db	R241:f385d571676276deb6c30be4d7274ab4644dd565	Feb 11 2020, 1:08 AM	★	★

Status	Author	Revision
Closed	kossebau	D27151 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27178 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27270 Use ecm_qt_install_logging_categories over manual categories files
Closed	kossebau	D27269 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27150 Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category