[Applet]Move toolbar to the bottom
AbandonedPublic

Authored by gvgeo on Feb 8 2020, 7:14 PM.

Details

Summary

Based on T10470.

Added line between search text field and buttons row.
Added disabled wifi, mobile, airplane mode messages.
And a No available connections message with a 5 second delay.
Replaced GridLayout of toolbar with RowLayout.

Depends on D27199.

Test Plan

Use buttons of the toolbar and make sure the correct message appears,
with appropriate delay.

Photos have the old buttons.

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
flip (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22259
Build 22277: arc lint + arc unit
gvgeo created this revision.Feb 8 2020, 7:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 8 2020, 7:14 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 8 2020, 7:14 PM
gvgeo edited the test plan for this revision. (Show Details)Feb 8 2020, 7:34 PM
gvgeo edited the test plan for this revision. (Show Details)Feb 8 2020, 7:36 PM
gvgeo edited the test plan for this revision. (Show Details)
gvgeo edited the test plan for this revision. (Show Details)Feb 8 2020, 7:40 PM
ngraham added a subscriber: ngraham.Feb 8 2020, 9:47 PM

While you're at it, can you center the disabledMessage label and make it a disabled Level 3 heading? See D27219.

gvgeo updated this revision to Diff 75291.Feb 9 2020, 10:51 AM
gvgeo edited the test plan for this revision. (Show Details)

Requested change

gvgeo edited the test plan for this revision. (Show Details)Feb 9 2020, 10:55 AM
gvgeo updated this revision to Diff 75293.Feb 9 2020, 11:16 AM

For some reason arc send both patches together here.
Updated with diff.

Why? That's make huge inconsistency, bluetooth applet has it on top, battery and brightness too.

gvgeo added a comment.Feb 9 2020, 11:21 AM

The was plan to move them all to the bottom, and there are patches for most of them. There is a recent small discussion about it in T10470.

you can close this task if you want, after talking a bit over T10470 it's better to use headers instead of footers

gvgeo abandoned this revision.Feb 9 2020, 7:19 PM