add maui index icon in pm style
AcceptedPublic

Authored by mbruchert on Feb 8 2020, 4:34 PM.

Details

Reviewers
camiloh
ndavis
Group Reviewers
VDG

Diff Detail

Repository
R266 Breeze Icons
Branch
index (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22239
Build 22257: arc lint + arc unit
mbruchert created this revision.Feb 8 2020, 4:34 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 8 2020, 4:34 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mbruchert requested review of this revision.Feb 8 2020, 4:34 PM
mbruchert updated this revision to Diff 75261.Feb 8 2020, 4:39 PM
  • fix shadow
camiloh accepted this revision.Feb 11 2020, 7:36 PM

I like it

This revision is now accepted and ready to land.Feb 11 2020, 7:36 PM
cblack accepted this revision as: VDG.Feb 11 2020, 7:43 PM
cblack added subscribers: ndavis, cblack.

This icon is visually nice, but it doesn't look 100% Breeze-y to me. I would see what feedback @ndavis has for the icon.

ndavis added a comment.EditedApr 24 2020, 11:50 AM

@cblack is right, breeze icons tend to be sharper, but there's no rule requiring sharpness and I've accepted similar icons recently (maybe I should edit those a bit, but they're still good). However, I'm not sure how we'll differentiate this from Dolphin if we make the corners sharper. For now, remove the dark blue bit in the top right. Sorry I missed this.

icons/apps/48/index.svg
29

The shadow gradient here got moved way out of place:

That happens sometimes when you use SVG cleaner.

35

This one can't be seen, so get rid of it.

ndavis added inline comments.Apr 24 2020, 11:53 AM
icons/apps/48/index.svg
35

Just realized this comment could be easily mistaken for me saying to get rid of the shadow because of how the phabricator UI looks. I'm talking about a blue rectangle.