Change message background on mouse hover
ClosedPublic

Authored by alessandro on Feb 8 2020, 1:30 PM.

Details

Summary

Change message background on mouse hover

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22233
Build 22251: arc lint + arc unit
alessandro requested review of this revision.Feb 8 2020, 1:30 PM
alessandro created this revision.
kfunk requested changes to this revision.Feb 10 2020, 7:38 AM
kfunk added inline comments.
src/apps/qml/qml/messages/MessageBase.qml
35

Just color: root.hovered ? RuqolaSingleton.alternateBackgroundColor : RuqolaSingleton.backgroundColor here instead of the onItemChanged handler, etc.? Seems simpler.

Side note: I think FancyMessageDelegate could be a plain Item now, now that MessageBase is a Button. Or?

This revision now requires changes to proceed.Feb 10 2020, 7:38 AM

@kfunk the way it is now we need both colors to be set, and they should be always consistent. It was a bit worse before in this sense, now we only have some left and right margin on each message that could be moved inside the specialized delegates. Until that's not done we need both colors to be set though.

kfunk added a comment.Feb 10 2020, 7:27 PM

Okay, could you please rebase that patch? No longer applies.

kfunk accepted this revision.Feb 11 2020, 8:02 AM
This revision is now accepted and ready to land.Feb 11 2020, 8:02 AM
This revision was automatically updated to reflect the committed changes.