Fix retrieving Twitter conversations
ClosedPublic

Authored by arojas on Feb 8 2020, 11:16 AM.

Details

Summary

Fix a regression from 0ecc05c1 where choqok can no longer retrieve Twitter conversations due to a mismatch between the authorization header and the actual post url

This was already fixed for requestTimeLine in f8285c35 but not for fetchPost

BUG: 417193

Test Plan

Clicked on "Display conversation" in a tweet from the timeline, no more authorization errors and the conversation is displayed correctly

Diff Detail

Repository
R186 Choqok
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas requested review of this revision.Feb 8 2020, 11:16 AM
arojas created this revision.
scarpino accepted this revision.Feb 11 2020, 10:06 AM
This revision is now accepted and ready to land.Feb 11 2020, 10:06 AM
scarpino closed this revision.Feb 11 2020, 10:08 AM

I'm sorry @arojas, I'm not sure what went wrong here:

This branch has revision 'D27236: Fix retrieving Twitter conversations'
but you are not the author. Land this revision by arojas? [y/N] y

But then I'm commit author. I really wouldn't have stolen the credits from you. I'm sorry.

No problem :)