port panel loading away from ksycoca
ClosedPublic

Authored by mart on Sep 9 2016, 10:25 AM.

Details

Summary

the panel tamplates are listed with kpackage listing
but were still loaded with kservicetypetrader
this made possible to have templates listed but not possible
to be loaded. This ports the template loading to the same logic
of the template listing, making thisgs consistent here

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 6580.Sep 9 2016, 10:25 AM
mart retitled this revision from to port panel loading away from ksycoca.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2016, 10:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a reviewer: Plasma.Sep 9 2016, 10:26 AM

the emtpy system tray (desktop right click add panel) shouldn't be a panel cause it doesn't work like a panel.

mart added a comment.Sep 9 2016, 10:50 AM

the emtpy system tray (desktop right click add panel) shouldn't be a panel cause it doesn't work like a panel.

good point, looking into that

davidedmundson requested changes to this revision.Sep 9 2016, 11:16 AM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
shell/scripting/scriptengine_v1.cpp
490

I'm a bit lost.

We have an argument to this method which is stored as local QString layout.

The old code found all Plasma/LayoutTemplates with that name.
As far as I can tell, this finds all LayoutTemplates which contain any panel?

(and if we're not using layout, why are we still checking it on line 483)

This revision now requires changes to proceed.Sep 9 2016, 11:16 AM
mart updated this revision to Diff 6584.Sep 9 2016, 11:35 AM
mart edited edge metadata.
  • actually check the panel plugin id
shell/scripting/scriptengine_v1.cpp
490

actual plugin name now checked (and the application name isn't something really used anymore)

davidedmundson accepted this revision.Sep 9 2016, 1:22 PM
davidedmundson edited edge metadata.
davidedmundson added inline comments.
shell/scripting/scriptengine_v1.cpp
488–492

if you do &layout

you'll save doing a copy every time

This revision is now accepted and ready to land.Sep 9 2016, 1:22 PM
mart updated this revision to Diff 6600.Sep 9 2016, 1:25 PM
mart edited edge metadata.
  • pass layout by reference
This revision was automatically updated to reflect the committed changes.