Update message items
AbandonedPublic
Actions

Authored by alessandro on Feb 7 2020, 11:09 PM.

Details

Reviewers

kfunk
nicolasfella
mlaurent
dfaure

Diff Detail

Repository

R865 Ruqola

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22221
Build 22239: arc lint + arc unit

alessandro requested review of this revision.Feb 7 2020, 11:09 PM

alessandro created this revision.

Harbormaster completed remote builds in B22204: Diff 75206.Feb 7 2020, 11:09 PM

Make MessageBase an Item instead of a ColumnLayout
Make MessageBase mouse aware
Show reaction button only when hovering on a message

Harbormaster completed remote builds in B22221: Diff 75237.Feb 8 2020, 12:14 PM

alessandro retitled this revision from Add missing include to Update message items.Feb 8 2020, 12:17 PM

alessandro added reviewers: kfunk, nicolasfella, mlaurent, dfaure.

mlaurent requested changes to this revision.Feb 8 2020, 12:43 PM

mlaurent added inline comments.

src/widgets/room/roomwidget.cpp
39	Another commit please

This revision now requires changes to proceed.Feb 8 2020, 12:43 PM

Couldn't remove the commit through arc, created a new patch with the QML changes only https://phabricator.kde.org/D27244

Show reaction button only when hovering on a message

Nice, tried to do that with extra MouseAreas but of course that didn't work out in QML ;)

One issue: When hovering through the the chat window the width of the message text is altered, looks a bit cumbersome. maybe it makes sense to just overlay the icon over the message text like RC does?

Will push this nevertheless.

Superseded by https://phabricator.kde.org/D27229

In D27229#608636, @kfunk wrote:

One issue: When hovering through the the chat window the width of the message text is altered, looks a bit cumbersome. maybe it makes sense to just overlay the icon over the message text like RC does?

Ah, fixed by: https://phabricator.kde.org/D27249 -- thanks!

Revision Contents
Changeset List

			Path	Packages
M			src/apps/qml/qml/messages/JitsiVideoMessage.qml (6 lines)
M			src/apps/qml/qml/messages/MessageBase.qml (3 lines)
M			src/apps/qml/qml/messages/SystemMessage.qml (5 lines)
M			src/apps/qml/qml/messages/UserMessage.qml (9 lines)
M			src/widgets/room/roomwidget.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	75206	4484477		Feb 7 2020, 11:09 PM	★	★
Diff 2	75237	4484477	- Make MessageBase an Item instead of a ColumnLayout	Feb 8 2020, 12:14 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bdb5735defdf	555e7141a214	9c478b3a4aab	Alessandro Ambrosano	Show reaction button only when hovering on a message	Feb 8 2020, 12:04 PM
9c478b3a4aab	b4ac2ae6d8b6	920cf5b13c6a	Alessandro Ambrosano	Make MessageBase mouse aware	Feb 8 2020, 12:03 PM
920cf5b13c6a	bec2411439b3	02a67f401333	Alessandro Ambrosano	Make MessageBase an Item instead of a ColumnLayout	Feb 8 2020, 11:53 AM
02a67f401333	ce4fec77ee41	44844770df7c	Alessandro Ambrosano	Add missing include (Show More…)	Feb 7 2020, 11:06 PM