MessageModel: fix dataChanged() not emitted for some images.
ClosedPublic
Actions

Authored by dfaure on Feb 7 2020, 10:05 PM.

Details

Reviewers

mlaurent
kfunk

Commits

R865:fd6a02ecd77f: MessageModel: fix dataChanged() not emitted for some images.

Summary

If attach.link() contains a space, the download URL (whose path ends up
in slotFileDownloaded) had %20 instead, so the lambda didn't match.
As a result, dataChanged() wasn't emitted, and the image would overlap
messages below it.

Test Plan

Send message with an image with a space in the name, remove cache,
restart ruqola.

Diff Detail

Repository

R865 Ruqola

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Feb 7 2020, 10:05 PM

dfaure created this revision.

Harbormaster completed remote builds in B22199: Diff 75201.Feb 7 2020, 10:05 PM

mlaurent accepted this revision.Feb 8 2020, 7:59 AM

This revision is now accepted and ready to land.Feb 8 2020, 7:59 AM

Closed by commit R865:fd6a02ecd77f: MessageModel: fix dataChanged() not emitted for some images. (authored by dfaure). · Explain WhyFeb 8 2020, 9:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/core/model/messagemodel.cpp (5 lines)
M			src/core/rocketchataccount.h (2 lines)
M			src/core/rocketchataccount.cpp (5 lines)
M			src/core/rocketchatcache.h (3 lines)
M			src/core/rocketchatcache.cpp (14 lines)