Optimization: only connect the current model to the account
ClosedPublic
Actions

Authored by dfaure on Feb 7 2020, 9:47 PM.

Details

Reviewers

mlaurent
kfunk

Commits

R865:dbc10d040f49: Optimization: only connect the current model to the account

Summary

Otherwise for each image being downloaded, the code was searching in
al messages of all models. Pretty wasteful.

Test Plan

Remove ~/.cache/ruqola, go to room with inline image.
Debug output in MessageModel went from 50 calls to just 1.
Only tested in widgets version, since the qml version crashes yet again.

Diff Detail

Repository

R865 Ruqola

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Feb 7 2020, 9:47 PM

dfaure created this revision.

Harbormaster completed remote builds in B22198: Diff 75200.Feb 7 2020, 9:47 PM

Seem logic

This revision is now accepted and ready to land.Feb 8 2020, 7:57 AM

Closed by commit R865:dbc10d040f49: Optimization: only connect the current model to the account (authored by dfaure). · Explain WhyFeb 8 2020, 9:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/apps/qml/qml/Desktop.qml (4 lines)
M			src/core/model/messagemodel.h (3 lines)
M			src/core/model/messagemodel.cpp (17 lines)
M			src/widgets/room/messagelistview.cpp (8 lines)