Differential D27226

Replace CopyFileJob with a two-liner call to QFile::copy
ClosedPublic
Actions

Authored by dfaure on Feb 7 2020, 9:00 PM.

Details

Reviewers
kfunk
mlaurent
Commits
R865:7e2f85893af8: Replace CopyFileJob with a two-liner call to QFile::copy
Summary

This isn't an async job.

A s/toString()/toLocalFile()/ bugfix along the way.
I can't trigger this code path from the widgets version, though.
Images are saved from pixmap, and files are saved after a download
(they are not in cache).

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22197
Build 22215: arc lint + arc unit
dfaure requested review of this revision.Feb 7 2020, 9:00 PM
dfaure created this revision.
mlaurent accepted this revision.Feb 8 2020, 8:01 AM
This revision is now accepted and ready to land.Feb 8 2020, 8:01 AM
Closed by commit R865:7e2f85893af8: Replace CopyFileJob with a two-liner call to QFile::copy (authored by dfaure). · Explain WhyFeb 8 2020, 9:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75199

View Options

src/core/CMakeLists.txt

Loading...
View Options

src/core/copyfilejob.h

Loading...
View Options

src/core/copyfilejob.cpp

Loading...
View Options

src/core/rocketchatcache.cpp

Loading...