add Kongress icon
Needs RevisionPublic

Authored by mbruchert on Feb 7 2020, 6:53 PM.

Details

Reviewers
dkardarakos
ndavis
Group Reviewers
VDG

Diff Detail

Repository
R266 Breeze Icons
Branch
kongress (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22196
Build 22214: arc lint + arc unit
mbruchert created this revision.Feb 7 2020, 6:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 7 2020, 6:53 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mbruchert requested review of this revision.Feb 7 2020, 6:53 PM

I like it and I will be happy to be the icon of Kongress. But let VDG people review it as well.

ndavis requested changes to this revision.Feb 15 2020, 5:36 PM
ndavis added a subscriber: ndavis.

The pixel alignment for all parts of the inner symbol is off. The style of the inner symbol is a bit too rounded for the breeze style as well. For instance, the podium should have sharper corners in order to look more like other breeze icons. I know it's not really easy to tell what can be rounded and what can't. That's something we need to nail down in the HIG. In general, use roundness where appropriate for a given shape, not as a general style. Objects that typically have sharp corners should generally be represented with sharp corners.

This revision now requires changes to proceed.Feb 15 2020, 5:36 PM

Created this MR to continue the review on invent.

Hello. FWIW, I would also close/abandon this diff :) (nice icon BTW).