Make PC3 ToolButton use SmallMedium icon size by default, to match other versions
AbandonedPublic
Actions

Authored by ngraham on Feb 7 2020, 6:18 PM.

Details

Reviewers

broulik
ndavis

Group Reviewers

VDG
Plasma

Summary

PC3 ToolButtons do not have the same size as PC2 and QWidgets ToolButtons. This patch
fixes that.

Test Plan

Now PC3 ToolButtons have the same size as PC2 and QWidgets ones by default if you don't
override the icon.height and icon.width properties.

Diff Detail

Repository

R242 Plasma Framework (Library)

Branch

fix-pc3-toolbutton-sizing (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22191
Build 22209: arc lint + arc unit

ngraham created this revision.Feb 7 2020, 6:18 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 7 2020, 6:18 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Feb 7 2020, 6:18 PM

Harbormaster completed remote builds in B22191: Diff 75191.Feb 7 2020, 6:18 PM

ngraham added a dependent revision: D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes.Feb 7 2020, 6:23 PM

gvgeo added a subscriber: gvgeo.Feb 7 2020, 7:29 PM

gvgeo added inline comments.

src/declarativeimports/plasmacomponents3/ToolButton.qml
58	Now will always be > 0, right?

ndavis accepted this revision.Feb 7 2020, 11:09 PM

This revision is now accepted and ready to land.Feb 7 2020, 11:09 PM

Good catch; only set icon height and width if an icon has actually been provided

Harbormaster completed remote builds in B22205: Diff 75208.Feb 8 2020, 5:02 AM

On second thought, maybe it was fine. Layout.preferredWidth should not have any effect when icon is not visible anyway. And negative value could be set if needed.

ndavis mentioned this in D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes.Feb 8 2020, 6:52 PM

ngraham added a dependent revision: D27260: [applets/systemtray] Set pin button's size correctly.Feb 8 2020, 9:33 PM

It could be my broken build. But this is what I see with X11 and scale 1.75.

davidedmundson mentioned this in D27260: [applets/systemtray] Set pin button's size correctly.Feb 9 2020, 2:13 PM

ngraham removed a dependent revision: D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes.Feb 10 2020, 7:27 PM

Looks like @mart just did this in D27396.

ngraham removed a dependent revision: D27260: [applets/systemtray] Set pin button's size correctly.Feb 14 2020, 2:17 PM

Revision Contents
Changeset List

			Path	Packages
M			src/declarativeimports/plasmacomponents3/ToolButton.qml (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	75191	b76b908		Feb 7 2020, 6:18 PM	★	★
Diff 2	75208	b76b908	Good catch; only set icon height and width if an icon has actually been provided	Feb 8 2020, 5:01 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6edc23aedc65	1f197b948dc8	b76b908e1056	Nate Graham	Make PC3 ToolButton use SmallMedium icon size by default, to match other… (Show More…)	Feb 7 2020, 6:17 PM

Diff 75191

View Options

src/declarativeimports/plasmacomponents3/ToolButton.qml