Differential D27212

Have pullback toolbars on scrollable pages also for footers
ClosedPublic
Actions

Authored by camiloh on Feb 7 2020, 2:57 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:7712c75953c5: Have pullback toolbars on scrollable pages also for footers

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22195
Build 22213: arc lint + arc unit
camiloh created this revision.Feb 7 2020, 2:57 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 7 2020, 2:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
camiloh requested review of this revision.Feb 7 2020, 2:57 PM
camiloh updated this revision to Diff 75195.Feb 7 2020, 6:50 PM

correct undefined line

mart requested changes to this revision.Feb 10 2020, 9:56 AM

almost there, just two minor nitpicks

src/controls/templates/AbstractApplicationHeader.qml
24

the maximum version you can import here is 2.4 as is the one released with qt 5.11 for which we depend from

100

remove extra whitespace

This revision now requires changes to proceed.Feb 10 2020, 9:56 AM
camiloh updated this revision to Diff 76337.Feb 25 2020, 12:33 AM

downgrade qqc2 version to 2.4 and remove white spaces

camiloh marked 2 inline comments as done.Feb 25 2020, 12:45 AM

everythign is now fixed :)

mart accepted this revision.Feb 26 2020, 1:34 PM
This revision is now accepted and ready to land.Feb 26 2020, 1:34 PM
Closed by commit R169:7712c75953c5: Have pullback toolbars on scrollable pages also for footers (authored by camiloh). · Explain WhyMar 6 2020, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75195

View Options

src/controls/templates/AbstractApplicationHeader.qml

Loading...