Added more checks and an error message.
Details
Details
- Reviewers
drosca ngraham - Group Reviewers
Plasma VDG - Commits
- R115:830bded4d30b: [Applet]Always get valid device and stream name
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Occasionally I get this.
kf5.ki18n: "0 instead of 1 arguments to message {Adjust volume for %1} supplied before conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Mute %1} supplied before conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Show additional opti...} supplied before conversion."
org.kde.plasma.pulseaudio: No object for name "alsa_output.pci-0000_00_1b.0.analog-stereo"
qrc:/plasma/plasmoids/org.kde.plasma.volume/contents/ui/ListItemBase.qml:118: TypeError: Value is undefined and could not be converted to an object
qrc:/plasma/plasmoids/org.kde.plasma.volume/contents/ui/ListItemBase.qml:144: TypeError: Value is undefined and could not be converted to an object
kf5.ki18n: "0 instead of 1 arguments to message {Adjust volume for %1} supplied before conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Mute %1} supplied before conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Show additional opti...} supplied before conversion."
org.kde.plasma.pulseaudio: No object for name "alsa_output.pci-0000_00_1b.0.analog-stereo"
org.kde.plasma.pulseaudio: No object for name "alsa_input.pci-0000_00_1b.0.analog-stereo"
org.kde.plasma.pulseaudio: No object for name "PulseEffects_apps.monitor"
org.kde.plasma.pulseaudio: No object for name "PulseEffects_apps.monitor"
org.kde.plasma.pulseaudio: No object for name "alsa_input.pci-0000_00_1b.0.analog-stereo"This patch will hide the warnings from the applet side and make it more foolproof.
The problem still exists.
Comment Actions
If this is something that should be shown to the user
It should not. It worked like that for years. I have never encounter this, as a UI bug. And I don't expect that I'll ever see that message.
It's more to avoid error messages. And for the rare occasion for a device not having a Description.
But if it exist, it can be shown to user. Feel sorry for the translators. This may never be read.