Differential D27203

Don't try to open files we can't figure out where they are
Needs RevisionPublic
Actions

Authored by apol on Feb 6 2020, 10:57 PM.

Details

Reviewers
dfaure
meven
ahmadsamir
Group Reviewers
Frameworks
Plasma
Test Plan

Been using it for a few days, no regressions.
Opening sftp:///localhost/.../somefile.text twice, doesn't try to open sftp:///localhost/.../somefile.text/

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22160
Build 22178: arc lint + arc unit
apol created this revision.Feb 6 2020, 10:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 6 2020, 10:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Feb 6 2020, 10:57 PM
meven accepted this revision.May 11 2020, 1:43 PM
meven added inline comments.
src/platformtheme/kdeplatformfiledialoghelper.cpp
226

QFileDialogPrivate::initialSelection

227

typo Selectingg

This revision is now accepted and ready to land.May 11 2020, 1:43 PM
dfaure requested changes to this revision.May 11 2020, 10:41 PM
dfaure added inline comments.
src/platformtheme/kdeplatformfiledialoghelper.cpp
226

That's not what that method says. It just says it can't know if the initial *selection* is a file or directory.

That's unrelated to what is the start directory.

QFileDialogPrivate::workingDirectory does support remote dirs.

This revision now requires changes to proceed.May 11 2020, 10:41 PM

Revision Contents
Changeset List

Diff 75147

View Options

src/platformtheme/kdeplatformfiledialoghelper.cpp

Loading...