Add an option to set the custom color of text under the cursor
AbandonedPublic

Authored by arthurk on Feb 6 2020, 9:37 PM.

Details

Reviewers
None
Group Reviewers
Konsole
VDG
Summary

Current version of Konsole allows to select the custom color of the cursor (Settings -> Edit Current Profile -> Appearance -> Cursor -> Custom cursor color). This works well for I-Beam and Underline cursor shapes. But for block-shaped cursors the text under the cursor is often hard to read, e.g. bright text under the bright cursor or dark text under the dark cursor.

This patch adds an ability to select the custom color of the character under the cursor. The character uses this color only when the cursor shape is Block and Konsole window is focused. Otherwise the character uses its foreground color as usual.

FEATURE: 407915
FIXED-IN: 20.04

Before:

After:

Settings window before:

Settings window after:

Diff Detail

Repository
R319 Konsole
Lint
Lint Skipped
Unit
Unit Tests Skipped
arthurk created this revision.Feb 6 2020, 9:37 PM
Restricted Application added a project: Konsole. · View Herald TranscriptFeb 6 2020, 9:37 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
arthurk requested review of this revision.Feb 6 2020, 9:37 PM

Thanks for the patch! Looks like it's your first one, nice.

Instead of "Cursor color:" and "Text color:", you could shorten them to "Cursor:" and "Text:"

BTW konsole is now on GitLab, so you might want to re-file this at https://invent.kde.org/kde/konsole/merge_requests/.

Hi Nathaniel,

Thank you for your suggestion! You're right, this is my first patch to KDE project.

Changed "Cursor color:" and "Text color:" to "Cursor:" and "Text:" respectively and created a merge request in GitLab. Let's move the discussion there.

https://invent.kde.org/kde/konsole/merge_requests/66

arthurk abandoned this revision.Feb 7 2020, 6:03 AM