BUG 410906 fix with added applicable handbook documentation
ClosedPublic

Authored by jhayes on Feb 6 2020, 8:38 PM.

Details

Summary

Fixed program pulling up a 'document not found' page to now pulling up the settings section in the handbook

Test Plan

run program and open settings dialog, press help button to be taken to handook in the settings section

Diff Detail

Repository
R139 Umbrello
Branch
BUG-410906
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22159
Build 22177: arc lint + arc unit
jhayes created this revision.Feb 6 2020, 8:38 PM
Restricted Application added projects: Documentation, Umbrello. · View Herald TranscriptFeb 6 2020, 8:38 PM
Restricted Application added subscribers: umbrello-devel, kde-doc-english. · View Herald Transcript
jhayes requested review of this revision.Feb 6 2020, 8:38 PM

Looks good, except for the missing file and the mentioned issues, which needs an update. Since this commit affects translations, and the stable branch is locked for changes, this commit would have to go to the master branch.

doc/settings.docbook
11 ↗(On Diff #75136)

This file is missing.

umbrello/dialogs/multipagedialogbase.cpp
276 ↗(On Diff #75136)

This line should also be changed: to help:/umbrello/settings.html

jhayes updated this revision to Diff 75146.Feb 6 2020, 10:44 PM
  • Change the other call to help and add missing image
habacker accepted this revision.Feb 6 2020, 11:44 PM

I'm going to apply this with a cleanup I found on testing this patch. Thanks for contributing

This revision is now accepted and ready to land.Feb 6 2020, 11:44 PM

I am rooting around now for what to work on next.

John

I am rooting around now for what to work on next.

There is a lot to do - If you want to add additional features in the current area, it may be that the implementation of this extension https://bugs.kde.org/show_bug.cgi?id=83444 would be what or https://bugs.kde.org/show_bug.cgi?id=120390

For the next stable release some things are already planned or underway and need a helping hand to finish. See below "IN PROGRESS" at https://community.kde.org/Schedules/release_service/20.04_Feature_Plan.

If that is not what you want or have more time there is a long list with a lot of feature requests and bugs at https://umbrello.kde.org/openbugs.php. The column 'Sev' indicates whether it is a feature request ('wis') or a bug. Bugfixes are usually easy to fix, but may be harder to find, extensions may be simple, but often require a design and/or prior redesign/refactoring to achieve the desired result. The more votes you have, the more complicated the associated tickets usually are. It can be a separate task to divide these tickets into easier to handle feature requests.

Thanks for your offer.

Sure, I will look at those, I do have a fair amount of time.

John

This revision was automatically updated to reflect the committed changes.