move all the logic in an attached property QObject
it's a bit less heavy to create so should make things slightly better
when this is used in delegates
Details
Details
- Reviewers
bshah - Group Reviewers
Plasma - Commits
- R242:68a273aef6c1: Make the attached property a simple QObject
Plasmoid background removal (with colors inversion) still works
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- phab/qobject
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22148 Build 22166: arc lint + arc unit
Comment Actions
LGTM otherwise
| src/declarativeimports/core/colorscope.cpp | ||
|---|---|---|
| 57 | let's make this a proper method? it's used twice here and a normal method should be quicker to use and easier on the reader. | |