Add symbolic screenshot icons
Needs ReviewPublic

Authored by mbruchert on Feb 6 2020, 6:26 PM.

Details

Reviewers
ngraham
lnj

Diff Detail

Repository
R266 Breeze Icons
Branch
sreenshot
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27170
Build 27188: arc lint + arc unit
mbruchert created this revision.Feb 6 2020, 6:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 6 2020, 6:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mbruchert requested review of this revision.Feb 6 2020, 6:26 PM
lnj added a comment.Feb 9 2020, 2:38 PM

This is required for the screenshot action in the panel of the plasma mobile shell. I don't know enough about creating breeze icons to approve this diff, but at least I don't see any problems.

lnj resigned from this revision.Feb 9 2020, 2:38 PM
ngraham requested changes to this revision.Feb 9 2020, 11:11 PM
ngraham added a subscriber: ngraham.

Please run the icons through an SVG optimizer and remove the color= attributes inside the paths.

See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips for more details.

Also, please add Breeze Dark versions in the icons-dark folder.

Finally, in terms of design, shouldn't the camera in this icon look like the camera used in other icons? For example camera-photo-symbolic

This revision now requires changes to proceed.Feb 9 2020, 11:11 PM
mbruchert updated this revision to Diff 83320.Jun 30 2020, 1:11 PM

Fix colors

Thanks, that's better now. However the camera silhouette still doesn't match that of other monochrome camera images we have. I'd like to stick to standard iconography if possible. Do you think we should switch the other related icons to use your new camera icon, or would you like to use the one from, for example, preferences-system-windows-effect-screenshot?